Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for interpolation in property name in custom-property-pattern #5949

Merged
merged 8 commits into from Mar 7, 2022
Merged

Fix false positives for interpolation in property name in custom-property-pattern #5949

merged 8 commits into from Mar 7, 2022

Conversation

kawaguchi1102
Copy link
Contributor

Which issue, if any, is this issue related to?

Closes #5945

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

jeddy3
jeddy3 requested changes Mar 3, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kawaguchi1102 Thanks for jumping on this.

Changes to rule code LGTM.

I've requested changes to the tests (as committable suggestions) to bring them in line with our conventions.

Note: You can either refactor in this pull request (or we can create a follow-up issue) to move the duplicated code into check(property) {} function. It's up to you.

lib/rules/custom-property-pattern/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/custom-property-pattern/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/custom-property-pattern/__tests__/index.js Outdated Show resolved Hide resolved
lib/rules/custom-property-pattern/__tests__/index.js Outdated Show resolved Hide resolved
kawaguchi1102 and others added 4 commits March 4, 2022 21:30
@kawaguchi1102 @jeddy3
Update lib/rules/custom-property-pattern/__tests__/index.js
7fe7792 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@kawaguchi1102 @jeddy3
Update lib/rules/custom-property-pattern/__tests__/index.js
16d52e8 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@kawaguchi1102 @jeddy3
Update lib/rules/custom-property-pattern/__tests__/index.js
10357df 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@kawaguchi1102 @jeddy3
Update lib/rules/custom-property-pattern/__tests__/index.js
503ed7b 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@kawaguchi1102
Copy link
Contributor Author

@jeddy3 Sorry, I must have missed it.
i've updated it now with what you said.

Note: You can either refactor in this pull request (or we can create a follow-up issue) to move the duplicated code into check(property) {} function. It's up to you.

That's a good idea!
I'll refactor with this PR.

@kawaguchi1102
Copy link
Contributor Author

@jeddy3 The refactor has been completed.
I hope I am not mistaken in this refactor.

jeddy3
jeddy3 reviewed Mar 6, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. LGTM!

I hope I am not mistaken in this refactor.

It's looks spot on to me, thank you.

ybiquitous
ybiquitous approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍🏼

@jeddy3 jeddy3 merged commit 890fc5d into stylelint:main Mar 7, 2022
@jeddy3
Copy link
Member

jeddy3 commented Mar 7, 2022

  • Fixed: custom-property-pattern false positives for interpolation in property name (#5949).

@sync-by-unito sync-by-unito bot mentioned this pull request May 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix false positives for interpolation in property name in custom-property-pattern
3 participants
@kawaguchi1102 @jeddy3 @ybiquitous